Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capture message in ApiError.stack #466

Merged
merged 5 commits into from
Sep 18, 2019
Merged

fix: capture message in ApiError.stack #466

merged 5 commits into from
Sep 18, 2019

Conversation

legraphista
Copy link
Contributor

@legraphista legraphista commented Aug 13, 2019 •
edited
Loading

Fixes #465

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Note:

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2019
@legraphista legraphista mentioned this pull request Aug 13, 2019
Closed
@JustinBeckwith JustinBeckwith requested a review from bcoe August 17, 2019 20:51
@legraphista
Copy link
Contributor Author

Any update on this?
Our error reporting system (https://sentry.io) uses Error.stack as its primary source of information.
Most of our GCP related errors just state:

Error: 
    at Http2CallStream.<anonymous> ([REDACTED]/node_modules/google-gax/node_modules/@grpc/grpc-js/build/src/client.js:96:45)
    at Http2CallStream.emit (events.js:214:15)
    at Http2CallStream.EventEmitter.emit (domain.js:476:20)
    at [REDACTED]

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #466 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   98.29%   98.29%   +<.01%     
==========================================
  Files           5        5              
  Lines         410      411       +1     
  Branches      101      101              
==========================================
+ Hits          403      404       +1     
  Misses          2        2              
  Partials        5        5
Impacted Files Coverage Δ
src/util.ts 98.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcef1a...9547c26. Read the comment docs.

@bcoe bcoe merged commit 811c7cd into googleapis:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith left review comments

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApiError missing stack message
5 participants
@legraphista @bcoe @JustinBeckwith @googlebot @kokoro-team